Issue 13505047: Remove literal overflow error reporting in compiler.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13505047: Remove literal overflow error reporting in compiler. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Zhenyao Mo

Modified:
13 years ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com, Shannon Woods

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Remove literal overflow error reporting in compiler. BUG= R=alokp@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=7343887

Patch Set 1 #

Patch Set 2 : version update #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -17 lines)			Patch
M	src/common/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/glslang.y	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Zhenyao Mo

Alok, please take a look. (I will add the version.h update upon landing.)

13 years ago (2013-09-09 19:21:39 UTC) #1

Zhenyao Mo

13 years ago (2013-09-09 20:16:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r7343887 (presubmit successful).

Expand All Messages | Collapse All Messages