Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8008)

Issue 13493044: worker: add debugging hooks for Runner

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
mue, fwereade, thumper, mp+184815
Visibility:
Public.

Description

worker: add debugging hooks for Runner This will make it possible for cmd/jujud tests to find out what's going on more directly. https://code.launchpad.net/~rogpeppe/juju-core/385-runner-debug/+merge/184815 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker: add debugging hooks for Runner #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/runner.go View 1 2 chunks +23 lines, -0 lines 2 comments Download
M worker/runner_test.go View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
10 years, 7 months ago (2013-09-10 15:54:07 UTC) #1
fwereade
Not sure about this -- let me know what you think. https://codereview.appspot.com/13493044/diff/3001/worker/runner.go File worker/runner.go (right): ...
10 years, 7 months ago (2013-09-10 16:01:25 UTC) #2
mue
Like William I would change this global DRA into a plug-able type. https://codereview.appspot.com/13493044/diff/3001/worker/runner.go File worker/runner.go ...
10 years, 7 months ago (2013-09-10 16:10:55 UTC) #3
thumper
10 years, 7 months ago (2013-09-19 22:34:03 UTC) #4
It seems to me that what we really want is some form of internal message bus.

Decouple the generation of messages from the consuming of them.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b