names: Support peer relations in tags and names

names: Support peer relations in tags and names

This adds support for peer relations in keys and
tags, which I missed before. The keys have the
format "service:relation" and the tags for peer
relations will be "relation-service.relationName".

https://code.launchpad.net/~dimitern/juju-core/132-names-peer-relations/+merge/185009

(do not edit description out of merge proposal)

[dimitern, 2013-09-11 10:22:44]

Please take a look.

[fwereade, 2013-09-11 10:28:11]

Does this impact tags at all?

https://codereview.appspot.com/13490045/diff/1/names/relation.go
File names/relation.go (left):

https://codereview.appspot.com/13490045/diff/1/names/relation.go#oldcode12
names/relation.go:12: const RelationSnippet = "[a-z][a-z0-9]*(-[a-z0-9]+)*"
Can we get away with dropping the digits in acceptable relation names? Or did we
find a charm that used them? (sorry, I didn't do the original CL IIRC)

[dimitern, 2013-09-11 10:45:35]

Please take a look.

https://codereview.appspot.com/13490045/diff/1/names/relation.go
File names/relation.go (left):

https://codereview.appspot.com/13490045/diff/1/names/relation.go#oldcode12
names/relation.go:12: const RelationSnippet = "[a-z][a-z0-9]*(-[a-z0-9]+)*"
On 2013/09/11 10:28:11, fwereade wrote:
> Can we get away with dropping the digits in acceptable relation names? Or did
we
> find a charm that used them? (sorry, I didn't do the original CL IIRC)

I don't think having digits as allowed chars in relation names is a big deal.

[fwereade, 2013-09-11 11:59:03]

LGTM