Issue 13490043: various: Relation tags use keys, not ids

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13490043: various: Relation tags use keys, not ids (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dimitern

Modified:
11 years, 7 months ago

Reviewers:
jameinel, mp+183634

Visibility:
Public.

Description

various: Relation tags use keys, not ids This changes the format of relation tags from "relation-id" to "relation-key", where the key has the format "svc1.rel1#svc2.rel2". Changed the relevant bits in names/ and state/ as needed. https://code.launchpad.net/~dimitern/juju-core/117-relation-tags-use-keys/+merge/183634 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -85 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	names/relation.go	View	1 chunk	+25 lines, -10 lines	0 comments	Download
M	names/relation_test.go	View	1 chunk	+22 lines, -9 lines	0 comments	Download
M	names/tag.go	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	names/tag_test.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View	2 chunks	+5 lines, -13 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	9 chunks	+36 lines, -36 lines	0 comments	Download
M	state/relation.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/state.go	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	state/state_test.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jameinel

11 years, 7 months ago (2013-09-03 12:56:46 UTC) #2

The actual code is all LGTM.

I don't actually prefer the structure of the keys, it seems like we are adding
complexity because we might someday use them as filenames (though we don't
actually ever do that today).

But if you have buy in from other people about the structure of the key, it
isn't a particularly big deal.

Expand All Messages | Collapse All Messages