Issue 13474046: various: Use params.IsCode*(err) helpers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13474046: various: Use params.IsCode*(err) helpers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dimitern

Modified:
11 years, 6 months ago

Reviewers:
mp+185461, fwereade

Visibility:
Public.

Description

various: Use params.IsCode*(err) helpers I'm getting sick of writing every time: if params.ErrCode(err) == params.CodeSomething So I added a bunch of IsCode*(err) helpers to simplify this. https://code.launchpad.net/~dimitern/juju-core/136-params-error-code-helpers/+merge/185461 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : various: Use params.IsCode*(err) helpers #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -96 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/agent.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/agent.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	state/api/agent/machine_test.go	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	state/api/agent/unit_test.go	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	state/api/deployer/deployer_test.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	state/api/machiner/machiner_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/api/params/apierror.go	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	state/api/uniter/relation_test.go	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	state/api/uniter/relationunit_test.go	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	state/api/uniter/unit_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/api/upgrader/upgrader_test.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	state/api/watcher/watcher.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/client/perm_test.go	View	1	9 chunks	+12 lines, -9 lines	0 comments	Download
M	state/apiserver/common/errors_test.go	View	1	3 chunks	+72 lines, -49 lines	0 comments	Download
M	worker/deployer/deployer.go	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	worker/machiner/machiner.go	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	worker/uniter/context.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	worker/uniter/filter.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	worker/uniter/uniter.go	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM https://codereview.appspot.com/13474046/diff/1/state/api/uniter/relation_test.go File state/api/uniter/relation_test.go (right): https://codereview.appspot.com/13474046/diff/1/state/api/uniter/relation_test.go#newcode71 state/api/uniter/relation_test.go:71: c.Assert(params.IsCodeUnauthorized(err), jc.IsTrue) FWIW these could be (err, jc.Satsifies, ...

11 years, 6 months ago (2013-09-13 10:45:22 UTC) #2

dimitern

11 years, 6 months ago (2013-09-13 11:37:03 UTC) #3

Please take a look.

https://codereview.appspot.com/13474046/diff/1/state/api/uniter/relation_test.go
File state/api/uniter/relation_test.go (right):

https://codereview.appspot.com/13474046/diff/1/state/api/uniter/relation_test...
state/api/uniter/relation_test.go:71: c.Assert(params.IsCodeUnauthorized(err),
jc.IsTrue)
On 2013/09/13 10:45:23, fwereade wrote:
> FWIW these could be (err, jc.Satsifies, params.IsCodeUnauthorized)
> 
> ...I think.

Good idea, done.

Expand All Messages | Collapse All Messages