Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 13469045: code review 13469045: testing: strip per-line whitespace during example outpu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by josharian
Modified:
8 years, 1 month ago
Reviewers:
r, adg
CC:
golang-dev
Visibility:
Public.

Description

testing: strip per-line whitespace during example output comparison Fixes issue 6416.

Patch Set 1 #

Patch Set 2 : diff -r 5981425e55ce https://code.google.com/p/go #

Patch Set 3 : diff -r 24bc2c8febe3 https://code.google.com/p/go #

Patch Set 4 : diff -r 24bc2c8febe3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M src/pkg/testing/example.go View 1 2 2 chunks +15 lines, -1 line 0 comments Download
A src/pkg/testing/example_test.go View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6
josharian
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 1 month ago (2013-12-14 02:16:07 UTC) #1
r
Why?
8 years, 1 month ago (2013-12-14 03:26:27 UTC) #2
josharian
On 2013/12/14 03:26:27, r wrote: > Why? I wanted to write an example whose output ...
8 years, 1 month ago (2013-12-14 16:05:55 UTC) #3
r
That sounds like a reason to write special code for that example, not change the ...
8 years, 1 month ago (2013-12-14 16:07:44 UTC) #4
josharian
> That sounds like a reason to write special code for that example, not > ...
8 years, 1 month ago (2013-12-14 16:14:02 UTC) #5
josharian
8 years, 1 month ago (2013-12-14 17:02:31 UTC) #6
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b