Avoid unused variable warning when NDEBUG

Avoid unused variable warning when NDEBUG

Otherwise, the Chromium Android build has errors like this when NDEBUG is defined.

FAILED: /mnt/scratch0/b_used/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/third_party/libphonenumber/src/phonenumbers/utf/libphonenumber_without_metadata.unicodetext.o.d -DCHROMIUM_BUILD -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1 -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_MANAGED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 -D__GNU_SOURCE=1 -DNDEBUG -DI18N_PHONENUMBERS_USE_ICU_REGEXP=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -I../.. -Igen -I../../third_party/libphonenumber/src -Igen/third_party/libphonenumber -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -fno-partial-inlining -fno-early-inlining -fno-tree-copy-prop -fno-tree-loop-optimize -fno-move-loop-invariants -fno-caller-saves -mfpu=vfpv3-d16 -Wall -Wsign-compare -Werror -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -isystem../../third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport -fvisibility=hidden --sysroot=/mnt/scratch0/b_used/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -Os -g2 -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -fno-rtti -fno-exceptions -c ../../third_party/libphonenumber/src/phonenumbers/utf/unicodetext.cc -o obj/third_party/libphonenumber/src/phonenumbers/utf/libphonenumber_without_metadata.unicodetext.o
../../third_party/libphonenumber/src/phonenumbers/utf/unicodetext.cc: In member function 'i18n::phonenumbers::UnicodeText::const_iterator i18n::phonenumbers::UnicodeText::MakeIterator(const char*) const':
../../third_party/libphonenumber/src/phonenumbers/utf/unicodetext.cc:499:15: error: unused variable 'end' [-Werror=unused-variable]
   const char* end = start + len;
               ^

BUG=chromium:335824

[Shaopeng, 2014-09-09 09:05:24]

Adding Fredrik, who has been kindly looking after the C++ code, as a reviewer

[roubert (google), 2014-09-09 10:08:20]

LGTM

[scottmg, 2014-09-09 17:22:18]

Thanks. Would someone be able to land it? I'm not a committer.

[roubert (google), 2014-09-09 17:29:37]

On 2014/09/09 17:22:18, scottmg wrote:
> Thanks. Would someone be able to land it? I'm not a committer.

https://code.google.com/p/libphonenumber/source/detail?r=700

[scottmg, 2014-09-09 17:43:50]

Thanks!

On Tue, Sep 9, 2014 at 10:29 AM, <roubert@google.com> wrote:

> On 2014/09/09 17:22:18, scottmg wrote:
>
>> Thanks. Would someone be able to land it? I'm not a committer.
>>
>
> https://code.google.com/p/libphonenumber/source/detail?r=700
>
> https://codereview.appspot.com/134650043/
>

[roubert (google), 2014-12-02 19:32:59]

On 2014/09/09 17:29:37, roubert (google) wrote:
> https://code.google.com/p/libphonenumber/source/detail?r=700

As the patch has been committed, you can delete this code review request.