api 1.17 & default Issue 836: Should clear URI query params when moving large URIs to POST

api 1.17 & default Issue 836: MethodOverride.java should clear URI query parameters when moving large URI's to post, otherwise request is rejected with "414 Request-URI Too Large".

This problem was acknowledged and the solution confirmed via empirical testing with the Translate API.

[peleyal, 2013-09-03 15:06:26]

LGTM

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
File
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java
(right):

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
[optional]
add a comment here that we remove query parameters, fragment, etc. from the Url.

[ngmiceli, 2013-09-03 15:42:14]

Submitting

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
File
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java
(right):

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:06:27, peleyal wrote:
> [optional]
> add a comment here that we remove query parameters, fragment, etc. from the
Url.

Turns out that the fragment is stored separately, so this only appears to clear
the query parameters. Wrote a comment accordingly.

[PAYASJUGS6969, 2015-12-14 08:40:44]

On 2013/09/03 15:06:26, peleyal wrote:
> LGTM
> 
>
https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
> File
>
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java
> (right):
> 
>
https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
>
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
> request.getUrl().clear();
> [optional]
> add a comment here that we remove query parameters, fragment, etc. from the
Url.

[PAYASJUGS6969, 2015-12-14 09:04:09]

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
File
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java
(right):

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:06:27, peleyal wrote:
> [optional]
> add a comment here that we remove query parameters, fragment, etc. from the
Url.

Done.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:06:27, peleyal wrote:
> [optional]
> add a comment here that we remove query parameters, fragment, etc. from the
Url.

Done.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:42:14, ngmiceli wrote:
> On 2013/09/03 15:06:27, peleyal wrote:
> > [optional]
> > add a comment here that we remove query parameters, fragment, etc. from the
> Url.
> 
> Turns out that the fragment is stored separately, so this only appears to
clear
> the query parameters. Wrote a comment accordingly.

Done.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:42:14, ngmiceli wrote:
> On 2013/09/03 15:06:27, peleyal wrote:
> > [optional]
> > add a comment here that we remove query parameters, fragment, etc. from the
> Url.
> 
> Turns out that the fragment is stored separately, so this only appears to
clear
> the query parameters. Wrote a comment accordingly.

Acknowledged.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:42:14, ngmiceli wrote:
> On 2013/09/03 15:06:27, peleyal wrote:
> > [optional]
> > add a comment here that we remove query parameters, fragment, etc. from the
> Url.
> 
> Turns out that the fragment is stored separately, so this only appears to
clear
> the query parameters. Wrote a comment accordingly.

Acknowledged.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:42:14, ngmiceli wrote:
> On 2013/09/03 15:06:27, peleyal wrote:
> > [optional]
> > add a comment here that we remove query parameters, fragment, etc. from the
> Url.
> 
> Turns out that the fragment is stored separately, so this only appears to
clear
> the query parameters. Wrote a comment accordingly.

Done.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
On 2013/09/03 15:06:27, peleyal wrote:
> [optional]
> add a comment here that we remove query parameters, fragment, etc. from the
Url.

Acknowledged.

https://codereview.appspot.com/13437043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java:100:
request.getUrl().clear();
RemovePlease remove queryparameters fragmnt,etc,from theUrlvquery paraOn
2013/09/03 15:06:27, peleyal wrote:
> [optional]
> add a comment here that we remove query parameters, fragment, etc. from the
Url.