Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(382)

Issue 13429045: Restructure the tests gyp so they can be included in chromium (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by Zhenyao Mo
Modified:
10 years, 6 months ago
Reviewers:
kbr1, Alok Priyadarshi
CC:
angleproject-review_googlegroups.com, Shannon Woods, Jamie Madill
Base URL:
https://code.google.com/p/angleproject/@master
Visibility:
Public.

Description

Restructure the tests gyp so they can be included in chromium BUG= R=alokp@chromium.org, kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=f84ef70

Patch Set 1 #

Patch Set 2 : per alokp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -55 lines) Patch
M tests/build_tests.gyp View 1 3 chunks +14 lines, -22 lines 0 comments Download
A + tests/compiler_tests/compiler_tests.gypi View 1 1 chunk +6 lines, -3 lines 0 comments Download
M tests/preprocessor_tests/input_test.cpp View 6 chunks +28 lines, -28 lines 0 comments Download
A tests/preprocessor_tests/preprocessor_tests.gypi View 1 1 chunk +35 lines, -0 lines 0 comments Download
M tests/preprocessor_tests/token_test.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Zhenyao Mo
Alok, Ken, please review. Shannon, Jamie, FYI. This is an effort to enable these tests ...
10 years, 6 months ago (2013-09-20 01:39:58 UTC) #1
Zhenyao Mo
chromium side CL is https://codereview.chromium.org/23509013/ So you get the whole picture.
10 years, 6 months ago (2013-09-20 01:43:32 UTC) #2
kbr1
Nice. LGTM
10 years, 6 months ago (2013-09-20 01:54:05 UTC) #3
Zhenyao Mo
Alok, any further comments on this?
10 years, 6 months ago (2013-09-20 17:44:06 UTC) #4
Alok Priyadarshi
lgtm I do not see diff for a couple of files.
10 years, 6 months ago (2013-09-20 17:57:35 UTC) #5
Zhenyao Mo
10 years, 6 months ago (2013-09-23 20:24:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as rf84ef70 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b