Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(479)

Issue 134260043: code review 134260043: runtime: add test for Stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bradfitz
Modified:
10 years, 7 months ago
Reviewers:
rsc
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: add test for Stack Would've caught the past two regressions. Update Issue 8626

Patch Set 1 #

Patch Set 2 : diff -r 7844c28fa2952f205ee365c89a213bb0c1627528 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7844c28fa2952f205ee365c89a213bb0c1627528 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/pkg/runtime/stack_test.go View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 7 months ago (2014-09-01 21:35:11 UTC) #1
rsc
test looks fine but it should be fixed first. are there issues filed that you ...
10 years, 7 months ago (2014-09-01 21:37:25 UTC) #2
bradfitz
I filed https://code.google.com/p/go/issues/detail?id=8626 with this same info, if that's what you wanted. On Mon, Sep ...
10 years, 7 months ago (2014-09-01 21:40:14 UTC) #3
rsc
Thanks. I've added this test to CL https://codereview.appspot.com/137050043 instead.
10 years, 7 months ago (2014-09-01 22:56:00 UTC) #4
bradfitz
10 years, 7 months ago (2014-09-01 23:39:42 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b