Issue 13413045: Show 5 downgrades, then expand link

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13413045: Show 5 downgrades, then expand link

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by matthew.scott

Modified:
10 years, 8 months ago

Reviewers:
mp+184865, benjamin.saller

Visibility:
Public.

Description

Show 5 downgrades, then expand link Per UX, this branch shows 5 downgrades with an expand link in the case of not having an upgrade available, rather than all downgrades at once. https://code.launchpad.net/~makyo/juju-gui/5-upgrades/+merge/184865 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -30 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/viewlets/service-overview.js	View	2 chunks	+22 lines, -12 lines	1 comment	Download
M	test/test_inspector_overview.js	View	8 chunks	+19 lines, -18 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

benjamin.saller

10 years, 8 months ago (2013-09-10 21:11:46 UTC) #2

Code LGTM, didn't QA

https://codereview.appspot.com/13413045/diff/1/app/views/viewlets/service-ove...
File app/views/viewlets/service-overview.js (right):

https://codereview.appspot.com/13413045/diff/1/app/views/viewlets/service-ove...
app/views/viewlets/service-overview.js:279: return
d.downgrades.slice(d.upgradeAvailable ? 0 : 5);
The number 5 occurs enough places here that you might want to define it a single
place.

Expand All Messages | Collapse All Messages