Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 134110044: Add GetAllocationSize support to CtMallocHeap. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by chrisha
Modified:
9 years, 8 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add GetAllocationSize support to CtMallocHeap. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2286

Patch Set 1 : #

Patch Set 2 : Added missing unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M syzygy/agent/asan/heap.h View 2 chunks +4 lines, -1 line 0 comments Download
M syzygy/agent/asan/heaps/ctmalloc_heap.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M syzygy/agent/asan/heaps/ctmalloc_heap_unittest.cc View 1 2 chunks +12 lines, -1 line 0 comments Download
M syzygy/agent/asan/heaps/internal_heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M syzygy/agent/asan/heaps/large_block_heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M syzygy/agent/asan/heaps/zebra_block_heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ctmalloc/wtf/PartitionAlloc.h View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4
chrisha
PTAL
9 years, 8 months ago (2014-08-29 17:55:00 UTC) #1
Sébastien Marchand
lgtm.
9 years, 8 months ago (2014-08-29 17:57:19 UTC) #2
chrisha
Thanks, committing!
9 years, 8 months ago (2014-08-29 18:43:22 UTC) #3
chrisha
9 years, 8 months ago (2014-08-29 18:44:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 2286 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b