Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12923)

Issue 13381045: api/uniter: APIAddresses call (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dimitern
Modified:
10 years, 7 months ago
Reviewers:
mp+184826, gz
Visibility:
Public.

Description

api/uniter: APIAddresses call Like the deployer, the uniter also needs to know the addresses of API servers, so I added this APIAddresses() API method to both server-side and client-side uniter API. In a follow-up, the format of the settings returned by ReadSettings() and their usage in the uniter will be changed from map[string]interface{} to the more appropriate params.Settings. https://code.launchpad.net/~dimitern/juju-core/131-api-uniter-apiaddresses/+merge/184826 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A state/api/uniter/state_test.go View 1 chunk +30 lines, -0 lines 0 comments Download
M state/api/uniter/uniter.go View 1 chunk +10 lines, -0 lines 0 comments Download
M state/api/uniter/uniter_test.go View 1 chunk +3 lines, -0 lines 0 comments Download
M state/apiserver/uniter/uniter.go View 2 chunks +27 lines, -0 lines 0 comments Download
M state/apiserver/uniter/uniter_test.go View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2
dimitern
Please take a look.
10 years, 7 months ago (2013-09-10 16:53:32 UTC) #1
gz
10 years, 7 months ago (2013-09-10 16:59:06 UTC) #2
LGTM as a stopgap.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b