Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 13381043: Add a _Deflater/_Inflater test against big random section input (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by tyoshino (chromium.org)
Modified:
13 years ago
Reviewers:
Yutaka Hirano
CC:
pywebsocket-reviews_googlegroups.com
Base URL:
http://pywebsocket.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add a _Deflater/_Inflater test against big random section input R=yhirano@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=785

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/test/test_util.py View 1 2 3 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5
tyoshino (chromium.org)
13 years, 1 month ago (2013-08-29 10:56:36 UTC) #1
Yutaka Hirano
https://codereview.appspot.com/13381043/diff/1/src/test/test_util.py File src/test/test_util.py (right): https://codereview.appspot.com/13381043/diff/1/src/test/test_util.py#newcode192 src/test/test_util.py:192: It is good to check there is no unconsumed ...
13 years, 1 month ago (2013-08-30 00:58:26 UTC) #2
tyoshino (chromium.org)
https://codereview.appspot.com/13381043/diff/1/src/test/test_util.py File src/test/test_util.py (right): https://codereview.appspot.com/13381043/diff/1/src/test/test_util.py#newcode192 src/test/test_util.py:192: On 2013/08/30 00:58:26, Yutaka Hirano wrote: > It is ...
13 years, 1 month ago (2013-09-06 07:17:24 UTC) #3
Yutaka Hirano
lgtm
13 years ago (2013-09-09 10:56:14 UTC) #4
tyoshino (chromium.org)
13 years ago (2013-09-10 03:12:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r785 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b