lgtm.
I'll just note for the record that it is expanding both the last message and the
last non-auto-generated message (which are most often the same but can be
different).
On 2014/09/08 16:41:44, jrobbins (corp) wrote:
> lgtm.
>
> I'll just note for the record that it is expanding both the last message and
the
> last non-auto-generated message (which are most often the same but can be
> different).
Yes correct. Eg: https://skia-codereview-staging2.appspot.com/3510001/
I left it this way intentionally, I figured expanding the last non-generated
message and last message (if it is generated) will be useful. Let me know if you
disagree (I do not think you do because of the lgtm).
yep, still lgtm.
On Mon, Sep 8, 2014 at 9:45 AM, <rmistry@google.com> wrote:
> On 2014/09/08 16:41:44, jrobbins (corp) wrote:
>
>> lgtm.
>>
>
> I'll just note for the record that it is expanding both the last
>>
> message and the
>
>> last non-auto-generated message (which are most often the same but can
>>
> be
>
>> different).
>>
>
> Yes correct. Eg: https://skia-codereview-staging2.appspot.com/3510001/
> I left it this way intentionally, I figured expanding the last
> non-generated message and last message (if it is generated) will be
> useful. Let me know if you disagree (I do not think you do because of
> the lgtm).
>
> https://codereview.appspot.com/133710044/
>
Issue 133710044: Expand last non-generated message
(Closed)
Created 11 years ago by rmistry
Modified 11 years ago
Reviewers: jrobbins (chromium), jrobbins (corp)
Base URL:
Comments: 0