Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(379)

Issue 13368050: Use the same mechanism to process int/float literals (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Zhenyao Mo
Modified:
10 years, 7 months ago
Reviewers:
Alok Priyadarshi
CC:
angleproject-review_googlegroups.com, nicolas, Shannon Woods
Base URL:
https://code.google.com/p/angleproject/@master
Visibility:
Public.

Description

Use the same mechanism to process int/float literals This also fixes the float overflow errno leaking bug. BUG= R=alokp@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=f382bff

Patch Set 1 #

Total comments: 4

Patch Set 2 : minor update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M src/common/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/util.cpp View 1 2 chunks +6 lines, -34 lines 0 comments Download

Messages

Total messages: 4
Zhenyao Mo
Alok, please take a look. Tested on my linux/windows with webgl conformance tests.
10 years, 7 months ago (2013-09-09 19:16:36 UTC) #1
Alok Priyadarshi
lgtm with minor comments. https://codereview.appspot.com/13368050/diff/1/src/compiler/util.cpp File src/compiler/util.cpp (right): https://codereview.appspot.com/13368050/diff/1/src/compiler/util.cpp#newcode7 src/compiler/util.cpp:7: #include "util.h" this should be ...
10 years, 7 months ago (2013-09-09 20:00:41 UTC) #2
Zhenyao Mo
https://codereview.appspot.com/13368050/diff/1/src/compiler/util.cpp File src/compiler/util.cpp (right): https://codereview.appspot.com/13368050/diff/1/src/compiler/util.cpp#newcode7 src/compiler/util.cpp:7: #include "util.h" On 2013/09/09 20:00:42, Alok Priyadarshi wrote: > ...
10 years, 7 months ago (2013-09-09 20:20:19 UTC) #3
Zhenyao Mo
10 years, 7 months ago (2013-09-09 20:20:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as rf382bff (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b