Issue 13361046: Proof of concept implementation for delete-surrounding-text.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13361046: Proof of concept implementation for delete-surrounding-text. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fujiwara

Modified:
12 years, 4 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus-qt.git@master

Visibility:
Public.

More Reviews

Description

Proof of concept implementation for delete-surrounding-text. The QInput method for committing text can be used to replace a region of text by an empty string, effectively allowing us to delete text. BUG=http://code.google.com/p/ibus/issues/detail?id=1642

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Fixed typo. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
M	qtim/ibus-input-context.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	qtim/ibus-input-context.cpp	View		2 chunks	+24 lines, -0 lines	0 comments	Download
M	src/interfaces/org.freedesktop.IBus.InputContext.xml	View	2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/qibusinputcontext.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/qibusinputcontext.cpp	View	2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/qibusinputcontextproxy.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm with one comment https://codereview.appspot.com/13361046/diff/1/src/qibusinputcontextproxy.h File src/qibusinputcontextproxy.h (right): https://codereview.appspot.com/13361046/diff/1/src/qibusinputcontextproxy.h#newcode129 src/qibusinputcontextproxy.h:129: void DeleteSurroundingText(int offset, uint nchars); ...

12 years, 4 months ago (2013-09-09 14:35:58 UTC) #2

fujiwara

12 years, 4 months ago (2013-09-10 01:41:25 UTC) #3

https://codereview.appspot.com/13361046/diff/1/src/qibusinputcontextproxy.h
File src/qibusinputcontextproxy.h (right):

https://codereview.appspot.com/13361046/diff/1/src/qibusinputcontextproxy.h#n...
src/qibusinputcontextproxy.h:129: void DeleteSurroundingText(int offset, uint
nchars);
On 2013/09/09 14:35:58, Peng wrote:
> alphabetical order

Done.

Expand All Messages | Collapse All Messages