Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4300)

Issue 13352052: Make show-log an explicit arg.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by thumper
Modified:
10 years, 7 months ago
Reviewers:
mp+185193, wallyworld
Visibility:
Public.

Description

Make show-log an explicit arg. This is part of the prelude to making --verbose mean something else. Also now, you can specify a log file and ask for show-log and the logging goes to both places. There is now a deprecation warning written out if people use --verbose. https://code.launchpad.net/~thumper/juju-core/show-log/+merge/185193 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -23 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/main_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/logging.go View 3 chunks +29 lines, -18 lines 0 comments Download
M cmd/logging_test.go View 6 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 3
thumper
Please take a look.
10 years, 7 months ago (2013-09-12 04:15:28 UTC) #1
wallyworld
Yay. LGTM
10 years, 7 months ago (2013-09-12 04:22:42 UTC) #2
wallyworld
10 years, 7 months ago (2013-09-12 04:22:56 UTC) #3
Yay. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b