Issue 13351043: testing: make LoggingSuite work during SetUpSuite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13351043: testing: make LoggingSuite work during SetUpSuite

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rog

Modified:
10 years, 8 months ago

Reviewers:
mue, mp+182714, natefinch, jameinel

Visibility:
Public.

Description

testing: make LoggingSuite work during SetUpSuite When trying to debug some code, I found that log messages were not being printed during SetUpSuite or TearDownSuite. This patch fixes LoggingSuite in that respect. https://code.launchpad.net/~rogpeppe/juju-core/379-loggingsuite-log-more/+merge/182714 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing: make LoggingSuite work during SetUpSuite #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	testing/log.go	View	3 chunks	+19 lines, -11 lines	2 comments	Download
A	testing/log_test.go	View	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

natefinch

On 2013/08/28 17:23:49, rog wrote: > Please take a look. LGTM

10 years, 8 months ago (2013-08-28 17:33:43 UTC) #2

jameinel

just a thought. https://codereview.appspot.com/13351043/diff/2/testing/log.go File testing/log.go (right): https://codereview.appspot.com/13351043/diff/2/testing/log.go#newcode30 testing/log.go:30: t.setUp(c) It seems a bit odd ...

10 years, 8 months ago (2013-08-28 17:57:01 UTC) #4

rog

10 years, 8 months ago (2013-08-28 17:59:09 UTC) #5

https://codereview.appspot.com/13351043/diff/2/testing/log.go
File testing/log.go (right):

https://codereview.appspot.com/13351043/diff/2/testing/log.go#newcode30
testing/log.go:30: t.setUp(c)
On 2013/08/28 17:57:01, jameinel wrote:
> It seems a bit odd to me to ghave 2 calls to setUp and only 1 call actually
> tearing things down.
> Shouldn't we reset everything after each test finishes?

If we reset everything after each test finishes, then we don't see any log
messages within the TearDownSuite call.

Expand All Messages | Collapse All Messages