Enable to run the bench multiple times and display stddev.

Enable to run the bench multiple times and display stddev.

Also added 'batch' button that runs send and receive benchmarks.

R=tyoshino@chromium.org

Committed: https://code.google.com/p/pywebsocket/source/detail?r=830

[tyoshino (chromium.org), 2014-09-04 04:20:40]

Nice

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:39: benchmark.startTimeInMs = 0;
ideally this should be in a separate CL

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:49: var summaryBox = null;
declared in util.js

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:187: var runners = [];
let's name this "tasks"

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:210: function nextBenchmark(config) {
config no longer needed

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:210: function nextBenchmark(config) {
name this runNextTask

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:213: addToLog('Finished');
destroyAllSockets();

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:256: var j;
please just declare loop variables in for statement

also I prefer i for out most loop if there's no special reason to use j

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:258: for (size = config.startSize, multiplierIndex =
0;
please give one line for multiplierIndex declaration with initialization

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:303: addResultReporting(config, 'Receive Benchmark');
addResultReportingTask

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:402: Summary
indent with two spaces

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:404: id="summary" rows="20" style="width: 100%"
readonly></textarea>
indent with four spaces

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js
File src/example/util.js (right):

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js#newco...
src/example/util.js:80: addToSummary('size[KiB]\taverage time[ms]\tstddev
time[ms]\tspeed[KB/s]');
capitalize the first letter to be consistent with the contents in the log box

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js#newco...
src/example/util.js:81: for(var size in results) {
space between for and (

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js#newco...
src/example/util.js:160: addToLog('FileReader Error: ' + reader.error.message);
ideally this should be in a separate CL

[hiroshige, 2014-09-04 05:39:36]

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:39: benchmark.startTimeInMs = 0;
I just moved this statement from Line 47 to do benchmark
declaration/initialization in one block.
Do you suggest to make this a separate refactoring CL because it is not related
to the things described in the CL description?

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:49: var summaryBox = null;
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> declared in util.js

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:187: var runners = [];
Done, also renamed addRunners to addTasks.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:210: function nextBenchmark(config) {
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> config no longer needed

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:210: function nextBenchmark(config) {
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> config no longer needed

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:213: addToLog('Finished');
On 2014/09/04 04:20:40, tyoshino (Chromium) wrote:
> destroyAllSockets();

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:256: var j;
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> please just declare loop variables in for statement
> 
> also I prefer i for out most loop if there's no special reason to use j

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:258: for (size = config.startSize, multiplierIndex =
0;
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> please give one line for multiplierIndex declaration with initialization

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:303: addResultReporting(config, 'Receive Benchmark');
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> addResultReportingTask

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:402: Summary
On 2014/09/04 04:20:40, tyoshino (Chromium) wrote:
> indent with two spaces

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:404: id="summary" rows="20" style="width: 100%"
readonly></textarea>
On 2014/09/04 04:20:39, tyoshino (Chromium) wrote:
> indent with four spaces

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js
File src/example/util.js (right):

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js#newco...
src/example/util.js:80: addToSummary('size[KiB]\taverage time[ms]\tstddev
time[ms]\tspeed[KB/s]');
On 2014/09/04 04:20:40, tyoshino (Chromium) wrote:
> capitalize the first letter to be consistent with the contents in the log box

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js#newco...
src/example/util.js:81: for(var size in results) {
On 2014/09/04 04:20:40, tyoshino (Chromium) wrote:
> space between for and (

Done.

https://codereview.appspot.com/133510044/diff/60001/src/example/util.js#newco...
src/example/util.js:160: addToLog('FileReader Error: ' + reader.error.message);
Done. I'll submit a separate CL later.

[tyoshino (chromium.org), 2014-09-04 06:06:12]

lgtm

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:39: benchmark.startTimeInMs = 0;
On 2014/09/04 05:39:35, hiroshige wrote:
> I just moved this statement from Line 47 to do benchmark
> declaration/initialization in one block.
> Do you suggest to make this a separate refactoring CL because it is not
related
> to the things described in the CL description?

Yes

https://codereview.appspot.com/133510044/diff/80001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/133510044/diff/80001/src/example/benchmark.htm...
src/example/benchmark.html:254: multiplierIndex = 0;
sorry. i meant moving this out of this for-loop.

please also add var.

[hiroshige, 2014-09-04 06:15:33]

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/133510044/diff/60001/src/example/benchmark.htm...
src/example/benchmark.html:39: benchmark.startTimeInMs = 0;
I see. Done.

https://codereview.appspot.com/133510044/diff/80001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/133510044/diff/80001/src/example/benchmark.htm...
src/example/benchmark.html:254: multiplierIndex = 0;
Done.

[hiroshige, 2014-09-04 06:17:53]

Committed patchset #6 (id:100001) manually as r830 (presubmit successful).