Warn on calling WeakMap as a function; ES5/3 log to console by default.

* Warn when WeakMap is called as a function rather than a constructor.
  Doing so is an error in ES6 spec drafts and Chrome Canary, so we
  should not be more lenient when using emulated maps.
  Fixes <https://code.google.com/p/google-caja/issues/detail?id=1832>.
* Use log-to-console.js in ES5/3 taming and guest frames; previously,
  cajaVM.log would go nowhere in ES5/3 mode.
* Update log-to-console.js to pass linter.

@r5595

[MarkM, 2013-09-10 22:33:30]

ses/* stuff LGTM

https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMa...
File src/com/google/caja/ses/WeakMap.js (right):

https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMa...
src/com/google/caja/ses/WeakMap.js:374: if (!(this instanceof OurWeakMap)) {
Add comment noting that this test is imperfect, in that rare violation cases
will appear legitimate. For example:

    var m = Object.create(WeakMap.prototype, {
        WeakMap: {value: WeakMap}
    }).WeakMap();

is a violation of the ES6 rule but will be judged legitimate by the above test.
In fact, it is extraordinarily hard to write a perfect test for this in ES5.
Since the purpose here is only to catch accident, this is fine.

https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMa...
src/com/google/caja/ses/WeakMap.js:521: // Be no more lenient than future ES6
WeakMap
Same comment should be reachable from both, either by copying or by reference.

[Mark S. Miller, 2013-09-10 22:38:18]

On Tue, Sep 10, 2013 at 3:33 PM, <erights@gmail.com> wrote:

> ses/* stuff LGTM
>
>
> https://codereview.appspot.**com/13348055/diff/1/src/com/**
>
google/caja/ses/WeakMap.js<https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMap.js>
> File src/com/google/caja/ses/**WeakMap.js (right):
>
> https://codereview.appspot.**com/13348055/diff/1/src/com/**
>
google/caja/ses/WeakMap.js#**newcode374<https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMap.js#newcode374>
> src/com/google/caja/ses/**WeakMap.js:374: if (!(this instanceof
> OurWeakMap)) {
> Add comment noting that this test is imperfect, in that rare violation
> cases will appear legitimate. For example:
>
>     var m = Object.create(WeakMap.**prototype, {
>         WeakMap: {value: WeakMap}
>     }).WeakMap();
>
> is a violation of the ES6 rule but will be judged legitimate by the
> above test. In fact, it is extraordinarily hard to write a perfect test
> for this in ES5.


Feel free to take this as a challenge, though probably not in this CL ;).




> Since the purpose here is only to catch accident, this
> is fine.
>
> https://codereview.appspot.**com/13348055/diff/1/src/com/**
>
google/caja/ses/WeakMap.js#**newcode521<https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMap.js#newcode521>
> src/com/google/caja/ses/**WeakMap.js:521: // Be no more lenient than
> future ES6 WeakMap
> Same comment should be reachable from both, either by copying or by
> reference.
>
>
https://codereview.appspot.**com/13348055/<https://codereview.appspot.com/133...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "Google Caja Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
google-caja-discuss+**unsubscribe@googlegroups.com<google-caja-discuss%2Bunsu...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>



-- 
    Cheers,
    --MarkM

[kpreid2, 2013-09-10 23:00:32]

* Warn when WeakMap is called as a function rather than a constructor.
  Doing so is an error in ES6 spec drafts and Chrome Canary, so we
  should not be more lenient when using emulated maps.
  Fixes <https://code.google.com/p/google-caja/issues/detail?id=1832>.
* Use log-to-console.js in ES5/3 taming and guest frames; previously,
  cajaVM.log would go nowhere in ES5/3 mode.
* Update log-to-console.js to pass linter.

[kpreid2, 2013-09-10 23:00:51]

https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMa...
File src/com/google/caja/ses/WeakMap.js (right):

https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMa...
src/com/google/caja/ses/WeakMap.js:374: if (!(this instanceof OurWeakMap)) {
On 2013/09/10 22:33:30, MarkM wrote:
> Add comment noting that this test is imperfect,

Done.

> In fact, it is extraordinarily hard to write a perfect test for this in ES5.
> Since the purpose here is only to catch accident, this is fine.

Indeed.

https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMa...
src/com/google/caja/ses/WeakMap.js:521: // Be no more lenient than future ES6
WeakMap
On 2013/09/10 22:33:30, MarkM wrote:
> Same comment should be reachable from both, either by copying or by reference.

Done.

[MarkM, 2013-09-10 23:35:37]

I went ahead and looked at the rest. All LGTM.