Issue 1334041: Experimental output of json instead of script

Issue 1334041: Experimental output of json instead of script (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by Jasvir

Modified:
15 years, 12 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Experimental output of json instead of script #

Patch Set 3 : Experimental output of json instead of script #

Patch Set 4 : Experimental output of json instead of script #

Total comments: 13

Created: 16 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+329 lines, -91 lines)			Patch
A	src/com/google/caja/service/AbstractCajolingHandler.java	View		1 chunk	+172 lines, -0 lines	8 comments	Download
M	src/com/google/caja/service/HtmlHandler.java	View	1	7 chunks	+17 lines, -45 lines	3 comments	Download
M	src/com/google/caja/service/JsHandler.java	View		3 chunks	+4 lines, -17 lines	0 comments	Download
M	src/com/google/caja/util/ContentType.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/service/HtmlHandlerTest.java	View	2	2 chunks	+71 lines, -0 lines	2 comments	Download
M	tests/com/google/caja/service/JsHandlerTest.java	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/com/google/caja/service/ServiceTestCase.java	View	2	4 chunks	+45 lines, -21 lines	0 comments	Download
M	tests/com/google/caja/util/CajaTestCase.java	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ihab.awad

LGTM++ http://codereview.appspot.com/1334041/diff/8001/9006 File src/com/google/caja/service/AbstractCajolingHandler.java (right): http://codereview.appspot.com/1334041/diff/8001/9006#newcode62 src/com/google/caja/service/AbstractCajolingHandler.java:62: * Common parent class for handlers that invoke ...

16 years ago (2010-06-17 01:12:57 UTC) #3

Jasvir

15 years, 12 months ago (2010-06-29 18:06:40 UTC) #4

snapshot

http://codereview.appspot.com/1334041/diff/8001/9006
File src/com/google/caja/service/AbstractCajolingHandler.java (right):

http://codereview.appspot.com/1334041/diff/8001/9006#newcode62
src/com/google/caja/service/AbstractCajolingHandler.java:62: * Common parent
class for handlers that invoke the cajoler and render the result
On 2010/06/17 01:12:57, ihab.awad wrote:
> Long line.

Done.

http://codereview.appspot.com/1334041/diff/8001/9006#newcode89
src/com/google/caja/service/AbstractCajolingHandler.java:89: public abstract
boolean canHandle(URI uri, CajolingService.Transform transform,
On 2010/06/17 01:12:57, ihab.awad wrote:
> Long line.

Done.

http://codereview.appspot.com/1334041/diff/8001/9006#newcode95
src/com/google/caja/service/AbstractCajolingHandler.java:95:
CajolingService.Transform transform,
On 2010/06/17 01:12:57, ihab.awad wrote:
> Indentation -- either align everything with "(" or indent all params 4 spaces.
> Elsewhere too....

Done.

http://codereview.appspot.com/1334041/diff/8001/9006#newcode152
src/com/google/caja/service/AbstractCajolingHandler.java:152:
output.append(json.toString());
On 2010/06/17 01:12:57, ihab.awad wrote:
> Looks good!

Done.

http://codereview.appspot.com/1334041/diff/8001/9005
File src/com/google/caja/service/HtmlHandler.java (right):

http://codereview.appspot.com/1334041/diff/8001/9005#newcode71
src/com/google/caja/service/HtmlHandler.java:71: uriFetcher != null ? uriFetcher
: UriFetcher.NULL_NETWORK);
It should.

On 2010/06/17 01:12:57, ihab.awad wrote:
> Should this conditional (uriFetcher...) be in the superclass?

Done.

http://codereview.appspot.com/1334041/diff/8001/9001
File tests/com/google/caja/service/HtmlHandlerTest.java (right):

http://codereview.appspot.com/1334041/diff/8001/9001#newcode124
tests/com/google/caja/service/HtmlHandlerTest.java:124:
registerUri("http://foo/bar.html", "<p>hi</p><script>42;</script><p>bye</p>",
On 2010/06/17 01:12:57, ihab.awad wrote:
> Long line

Done.

Expand All Messages | Collapse All Messages