src/cmd/gc/popt.h - Issue 13334052: code review 13334052: cmd/gc: eliminate redundant &x.Field nil checks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/cmd/gc/popt.h

Issue 13334052: code review 13334052: cmd/gc: eliminate redundant &x.Field nil checks (Closed)

Left Patch Set: Created 11 years, 6 months ago

Right Patch Set: diff -r 2e735aa41d4a https://code.google.com/p/go/ Created 11 years, 6 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 // Copyright 2013 The Go Authors. All rights reserved.	1 // Copyright 2013 The Go Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style	2 // Use of this source code is governed by a BSD-style

3 // license that can be found in the LICENSE file.	3 // license that can be found in the LICENSE file.

4	4

5 typedef struct Flow Flow;	5 typedef struct Flow Flow;

6 typedef struct Graph Graph;	6 typedef struct Graph Graph;

7	7

8 struct Flow {	8 struct Flow {

9 Prog* prog; // actual instruction	9 Prog* prog; // actual instruction

10 Flow* p1; // predecessors of this instruction: p1,	10 Flow* p1; // predecessors of this instruction: p1,

(...skipping 18 matching lines...) Expand all Loading...
29 // After calling flowrpo, rpo lists the flow nodes in reverse postorder,	29 // After calling flowrpo, rpo lists the flow nodes in reverse postorder,

30 // and each non-dead Flow node f has g->rpo[f->rpo] == f.	30 // and each non-dead Flow node f has g->rpo[f->rpo] == f.

31 Flow** rpo;	31 Flow** rpo;

32 };	32 };

33	33

34 void fixjmp(Prog*);	34 void fixjmp(Prog*);

35 Graph* flowstart(Prog*, int);	35 Graph* flowstart(Prog*, int);

36 void flowrpo(Graph*);	36 void flowrpo(Graph*);

37 void flowend(Graph*);	37 void flowend(Graph*);

38 void mergetemp(Prog*);	38 void mergetemp(Prog*);

	39 void nilopt(Prog*);

39 int noreturn(Prog*);	40 int noreturn(Prog*);

40 int regtyp(Addr*);	41 int regtyp(Addr*);

	42 int sameaddr(Addr, Addr);

	43 int smallindir(Addr, Addr);

	44 int stackaddr(Addr*);

41 Flow* uniqp(Flow*);	45 Flow* uniqp(Flow*);

42 Flow* uniqs(Flow*);	46 Flow* uniqs(Flow*);

LEFT	RIGHT