Issue 1333042: Fix the location field for MediaItem to use Address instead of String

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1333042: Fix the location field for MediaItem to use Address instead of String (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by henry.saputra

Modified:
15 years ago

Reviewers:
chirag, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Based on 0.9 spec: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Specification.html#opensocial.MediaItem.Field.LOCATION The type of MediaItem.location should be opensocial.Address instead of String.

Patch Set 1 #

Patch Set 2 : Update location string. #

Patch Set 3 : Add import for Address #

Patch Set 4 : Change ordering of imports #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/MediaItemDb.java	View	1 2 3	3 chunks	+6 lines, -5 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/core/model/MediaItemImpl.java	View		3 chunks	+4 lines, -3 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/MediaItem.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamAtomConverterTest.java	View	1	4 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

henry.saputra

15 years, 10 months ago (2010-05-26 22:09:12 UTC) #1

Proposed fix for changing MediaItem.location to use opensocial Address as type
instead of string.

Based on OpenSocial 0.9 specification:
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-...

The MediaItem.Field.location should be type of opensocial.Address instead of
String.

Thx,

- Henry

Expand All Messages | Collapse All Messages