Issue 13324052: api/uniter: ErrNoCharmURLSet, ProviderType

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13324052: api/uniter: ErrNoCharmURLSet, ProviderType (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dimitern

Modified:
11 years, 6 months ago

Reviewers:
mp+185090, fwereade

Visibility:
Public.

Description

api/uniter: ErrNoCharmURLSet, ProviderType Last few bits of the uniter API needed: * ProviderType() implemented (I omitted that before) * unit.CharmURL now returns ErrNoCharmURLSet concrete error when there's no charm url set, as this is needed in the uniter filter to distinguish between "no charm url set" and other errors. * Fixed a typo in a doc comment and some other misc improvements. https://code.launchpad.net/~dimitern/juju-core/132-api-uniter-last-fixes/+merge/185090 Requires: https://code.launchpad.net/~dimitern/juju-core/132-names-peer-relations/+merge/185009 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/uniter/state_test.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	state/api/uniter/unit.go	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	state/api/uniter/unit_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/uniter/uniter.go	View	2 chunks	+13 lines, -3 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages