Expose the packing function so we can check varyings packing per program

Expose the packing function so we can check varyings packing per program

ANGLEBUG=471
R=kbr@chromium.org

Committed: https://code.google.com/p/angleproject/source/detail?r=0bd6d11

[Zhenyao Mo, 2013-08-28 01:48:22]

kbr: please review.

Shannon, Jamie, FYI.  Shannon, please merge back to ES3 proto branch once it
lands.

[Zhenyao Mo, 2013-08-28 01:49:23]

Chrome side is also implemented.  Running against webgl conformance tests, no
regressions, and the related failing test is passing now.

Also run against a bunch of webgl demo.

[Zhenyao Mo, 2013-08-28 01:53:53]

On 2013/08/28 01:49:23, Zhenyao Mo wrote:
> Chrome side is also implemented.  Running against webgl conformance tests, no
> regressions, and the related failing test is passing now.
> 
> Also run against a bunch of webgl demo.

FYI: chromium side CL is here: https://codereview.chromium.org/23534007/

Chromium side CL is not ready for review yet.  I need to add the ANGLE roll once
this lands, and also the gpu_unittests.

[kbr1, 2013-08-29 01:44:24]

LGTM

https://codereview.appspot.com/13322043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/13322043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:165: // Enforce the GLSL 1.017 Appendix A section 7
packing restrictions.
Please add a note here that this flag only enforces (and can only enforce) the
packing restrictions for uniform variables in both vertex and fragment shaders,
and that ShCheckVariablesWithinPackingLimits lets embedders enforce the packing
restrictions for varying variables during program link time.

https://codereview.appspot.com/13322043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:445: // Returns 0 otherwise.
Please add a note to look at the SH_ENFORCE_PACKING_RESTRICTIONS flag above.

[Zhenyao Mo, 2013-08-29 22:16:37]

https://codereview.appspot.com/13322043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/13322043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:165: // Enforce the GLSL 1.017 Appendix A section 7
packing restrictions.
On 2013/08/29 01:44:24, kbr1 wrote:
> Please add a note here that this flag only enforces (and can only enforce) the
> packing restrictions for uniform variables in both vertex and fragment
shaders,
> and that ShCheckVariablesWithinPackingLimits lets embedders enforce the
packing
> restrictions for varying variables during program link time.

Done.

https://codereview.appspot.com/13322043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:445: // Returns 0 otherwise.
On 2013/08/29 01:44:24, kbr1 wrote:
> Please add a note to look at the SH_ENFORCE_PACKING_RESTRICTIONS flag above.

Done.

[Zhenyao Mo, 2013-08-29 22:23:30]

Committed patchset #3 manually as r0bd6d11 (presubmit successful).