Issue 13302054: apiserver: SetAgentAlive for machines and units

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13302054: apiserver: SetAgentAlive for machines and units (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dimitern

Modified:
10 years, 7 months ago

Reviewers:
mp+185280, fwereade, rog

Visibility:
Public.

Description

apiserver: SetAgentAlive for machines and units Minor refactoring to ensure SetAgentAlive is called upon a successful machine/unit agent API login, so the machine/unit won't be displayed as "down" in juju status. https://code.launchpad.net/~dimitern/juju-core/133-apiserver-setagentalive-for-unit-agents/+merge/185280 Requires: https://code.launchpad.net/~dimitern/juju-core/133-agent-fix-openapistate/+merge/185119 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -34 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/apiserver/admin.go	View	1 chunk	+8 lines, -3 lines	2 comments	Download
M	state/apiserver/server_test.go	View	1 chunk	+62 lines, -31 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM with one minor suggestion. https://codereview.appspot.com/13302054/diff/1/state/apiserver/admin.go File state/apiserver/admin.go (right): https://codereview.appspot.com/13302054/diff/1/state/apiserver/admin.go#newcode135 state/apiserver/admin.go:135: newRoot.resources.Register(&machinePinger{pinger}) "machinePinger" is now ...

10 years, 7 months ago (2013-09-12 15:15:59 UTC) #3

dimitern

10 years, 7 months ago (2013-09-12 15:20:23 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/13302054/diff/1/state/apiserver/admin.go
File state/apiserver/admin.go (right):

https://codereview.appspot.com/13302054/diff/1/state/apiserver/admin.go#newco...
state/apiserver/admin.go:135: newRoot.resources.Register(&machinePinger{pinger})
On 2013/09/12 15:15:59, rog wrote:
> "machinePinger" is now a bit of a misnomer because it applies to any entity.
> 
> how about pingerResource ?

Sorry, missed that. Will include that suggestion in the next follow-up.

Expand All Messages | Collapse All Messages