Issue 13302053: sync tools uses simplestreams

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13302053: sync tools uses simplestreams (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by wallyworld

Modified:
11 years, 6 months ago

Reviewers:
mp+185189, thumper

Visibility:
Public.

Description

sync tools uses simplestreams The main purpose of this branch is to convert sync tools so that it copies the tools and writes simplestreams metadata to the destination data source. The achieve the goal, a fair bit of refactoring needed to be done, primarily to extract code from the tools metadata plugin and share it with the sync tools command. Extra code was also needed to ensure the legacy tools loading code could use the new releases directory but also fall back to the old location. https://code.launchpad.net/~wallyworld/juju-core/simplestreams-sync-tools/+merge/185189 Requires: https://code.launchpad.net/~wallyworld/juju-core/simplestreams-control-bucket-2/+merge/184720 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : sync tools uses simplestreams #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+669 lines, -396 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View		3 chunks	+14 lines, -14 lines	0 comments	Download
M	cmd/juju/cmd_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/juju/synctools.go	View	1	4 chunks	+22 lines, -13 lines	0 comments	Download
M	cmd/juju/synctools_test.go	View		3 chunks	+22 lines, -11 lines	0 comments	Download
M	cmd/logging.go	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata.go	View	1	3 chunks	+10 lines, -115 lines	0 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata_test.go	View	1	5 chunks	+51 lines, -120 lines	0 comments	Download
M	environs/filestorage/filestorage.go	View	1	3 chunks	+41 lines, -6 lines	0 comments	Download
A	environs/filestorage/filestorage_test.go	View	1	1 chunk	+103 lines, -0 lines	0 comments	Download
M	environs/sync/sync.go	View	1	7 chunks	+36 lines, -63 lines	0 comments	Download
M	environs/sync/sync_test.go	View	1	7 chunks	+28 lines, -47 lines	0 comments	Download
M	environs/tools/simplestreams.go	View		3 chunks	+89 lines, -1 line	0 comments	Download
M	environs/tools/simplestreams_test.go	View		2 chunks	+74 lines, -0 lines	0 comments	Download
M	environs/tools/storage.go	View	1	3 chunks	+21 lines, -1 line	0 comments	Download
M	environs/tools/storage_test.go	View		2 chunks	+14 lines, -1 line	0 comments	Download
A	environs/tools/testing/testing.go	View		1 chunk	+105 lines, -0 lines	0 comments	Download
M	environs/tools/tools.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	environs/tools/tools_test.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/tools.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

11 years, 6 months ago (2013-09-12 05:15:12 UTC) #3

On 2013/09/12 05:08:17, wallyworld wrote:
> Please take a look.

LGTM, for other followers, the merge proposal had the original review.

Expand All Messages | Collapse All Messages