Issue 132900045: Static cast the timestamp to long for serialization.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 132900045: Static cast the timestamp to long for serialization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by Rouslan Solomakhin

Modified:
9 years, 8 months ago

Reviewers:
roubert (google)

CC:
lararennie, thakis, davinci_google, dbeaumont, keghani

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Static cast the timestamp to long for serialization. This patch static casts the timestamp to long for serialization of timestamps on systems that that use long long time. That should be good enough until 2037. R=roubert@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=334

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	cpp/src/validating_util.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Rouslan Solomakhin

Fredrik: PTAL Patch Set 1. (Re: discussion in https://codereview.appspot.com/109120043/.)

9 years, 9 months ago (2014-08-26 00:11:25 UTC) #1

Rouslan Solomakhin

Committed patchset #1 manually as 334 (presubmit successful).

9 years, 8 months ago (2014-08-26 17:11:43 UTC) #3

Rouslan Solomakhin

9 years, 8 months ago (2014-08-26 17:15:43 UTC) #4

Message was sent while issue was closed.

https://drone.io/rsolomakhin/libaddressinput/12
This build successfully completed. Commit: 334

:-D

Expand All Messages | Collapse All Messages