Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 13283043: http: Add android properties file for google-http-client-jdo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by ngmiceli
Modified:
12 years ago
Reviewers:
yanivi
Base URL:
https://code.google.com/p/google-http-java-cient/
Visibility:
Public.

Description

http: Add android properties file for google-http-client-jdo

Patch Set 1 #

Patch Set 2 : Added jdo artifact detail to readme #

Total comments: 1

Patch Set 3 : readme: jackson update #

Total comments: 2

Patch Set 4 : readme fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
A google-http-client-assembly/android-properties/google-http-client-jdo-1.18.0-rc-SNAPSHOT.jar.properties View 1 chunk +1 line, -0 lines 0 comments Download
M google-http-client-assembly/readme.html View 1 2 3 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 7
ngmiceli
12 years ago (2013-08-27 15:29:43 UTC) #1
yanivi
OK, but please also add it to readme.html file also, please update both default & ...
12 years ago (2013-08-27 15:35:02 UTC) #2
ngmiceli
On 2013/08/27 15:35:02, yanivi wrote: > OK, but please also add it to readme.html file ...
12 years ago (2013-08-27 15:39:56 UTC) #3
yanivi
https://codereview.appspot.com/13283043/diff/5001/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): https://codereview.appspot.com/13283043/diff/5001/google-http-client-assembly/readme.html#newcode98 google-http-client-assembly/readme.html:98: <li>google-http-client-jackson-${project.version}.jar (when using let's put jackson2 first and say ...
12 years ago (2013-08-27 15:42:10 UTC) #4
ngmiceli
On 2013/08/27 15:42:10, yanivi wrote: > https://codereview.appspot.com/13283043/diff/5001/google-http-client-assembly/readme.html > File google-http-client-assembly/readme.html (right): > > https://codereview.appspot.com/13283043/diff/5001/google-http-client-assembly/readme.html#newcode98 > ...
12 years ago (2013-08-27 15:48:10 UTC) #5
yanivi
LGTM https://codereview.appspot.com/13283043/diff/11001/google-http-client-assembly/readme.html File google-http-client-assembly/readme.html (right): https://codereview.appspot.com/13283043/diff/11001/google-http-client-assembly/readme.html#newcode104 google-http-client-assembly/readme.html:104: <li>google-http-client-jackson-${project.version}.jar (for backwards compatability when using Jackson) Jackson ...
12 years ago (2013-08-27 15:56:28 UTC) #6
ngmiceli
12 years ago (2013-08-27 15:58:11 UTC) #7 
https://codereview.appspot.com/13283043/diff/11001/google-http-client-assembl...
File google-http-client-assembly/readme.html (right):

https://codereview.appspot.com/13283043/diff/11001/google-http-client-assembl...
google-http-client-assembly/readme.html:104:
<li>google-http-client-jackson-${project.version}.jar (for backwards
compatability when using Jackson)
On 2013/08/27 15:56:29, yanivi wrote:
> Jackson 1

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b