Issue 13271044: Support string callbacks in setTimeout in ES5 mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13271044: Support string callbacks in setTimeout in ES5 mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by kpreid2

Modified:
12 years, 6 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

https://code.google.com/p/google-caja/issues/detail?id=1821 @r5581

Patch Set 2 : Support string callbacks in setTimeout in ES5 mode. #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -24 lines)			Patch
	M	src/com/google/caja/plugin/domado.js	View	1	4 chunks	+48 lines, -24 lines	0 comments	Download
	M	tests/com/google/caja/plugin/test-domado-events-guest.html	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ihab.awad

lgtm++ https://codereview.appspot.com/13271044/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/13271044/diff/1/src/com/google/caja/plugin/domado.js#newcode1445 src/com/google/caja/plugin/domado.js:1445: // call, syntax occurs occur async. You mean ...

12 years, 6 months ago (2013-08-27 23:48:55 UTC) #2

kpreid2

https://code.google.com/p/google-caja/issues/detail?id=1821

12 years, 6 months ago (2013-08-28 16:34:04 UTC) #3

kpreid2

https://codereview.appspot.com/13271044/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/13271044/diff/1/src/com/google/caja/plugin/domado.js#newcode1445 src/com/google/caja/plugin/domado.js:1445: // call, syntax occurs occur async. On 2013/08/27 23:48:55, ...

12 years, 6 months ago (2013-08-28 16:34:48 UTC) #4

Cool, thanks! lgtm++

Expand All Messages | Collapse All Messages