Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6562)

Issue 13269052: Store logging config in the environ config.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by thumper
Modified:
10 years, 7 months ago
Reviewers:
mp+185392, wallyworld
Visibility:
Public.

Description

Store logging config in the environ config. There are two main changes here. Firstly is an environment variable for the logging config. This provides a source for the default logging config should none be explicity set. This is handled in two places: the Log command helper; and the new config settings. The second is to store the logging config in the environment config. This is used in upcoming changes to configure the agents. https://code.launchpad.net/~thumper/juju-core/logging-in-environment/+merge/185392 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -42 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/logging.go View 2 chunks +4 lines, -1 line 0 comments Download
M cmd/logging_test.go View 5 chunks +47 lines, -25 lines 0 comments Download
M environs/config/config.go View 6 chunks +24 lines, -0 lines 0 comments Download
M environs/config/config_test.go View 6 chunks +38 lines, -3 lines 0 comments Download
M juju/osenv/vars.go View 1 chunk +4 lines, -3 lines 0 comments Download
M testing/environ.go View 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 2
thumper
Please take a look.
10 years, 7 months ago (2013-09-12 23:37:16 UTC) #1
wallyworld
10 years, 7 months ago (2013-09-12 23:47:39 UTC) #2
LGTM but I was confused when I read "environment", as in the Juju context, that
means something different to environment variables. eg we talk about environment
constraints as being stored in the environment, which means in state in mgo.
Could you consider changing the text to talk about environment variables?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b