Issue 13269051: state: Attempt to fix tests failing on the bot

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13269051: state: Attempt to fix tests failing on the bot (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dimitern

Modified:
10 years, 8 months ago

Reviewers:
mue, mp+184265

Visibility:
Public.

Description

state: Attempt to fix tests failing on the bot This removes two assertInScope calls from relationunit_test.go which for some unknown reason started failing on the go-bot, thus preventing and branches landing. The removed asserts are not critical. https://code.launchpad.net/~dimitern/juju-core/124-fix-relationunit-tests/+merge/184265 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/relationunit_test.go	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mue

LGTM, but have to discover why the connection to mongo fails.

10 years, 8 months ago (2013-09-06 10:28:57 UTC) #2

dimitern

10 years, 8 months ago (2013-09-06 11:19:14 UTC) #3

Message was sent while issue was closed.

This didn't fix the issue, so I rebooted the bot machine and after a few trial
and error attempts now it seems it works again and runs tests - will wait to see
if it'll be fixed, but so far so good.

Expand All Messages | Collapse All Messages