Issue 13248043: Fix using the incorrect vertex count in instancing drawing using the streaming buffer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13248043: Fix using the incorrect vertex count in instancing drawing using the streaming buffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Jamie Madill

Modified:
10 years, 7 months ago

Reviewers:
Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Fix using the incorrect vertex count in instancing drawing using the streaming buffer. This could cause visual corruption from reading past the end of initialized vertex data. Also fix a regression in instanced drawing in VertexBuffer9.cpp. ANGLEBUG=467 Test=WebGL CTS 1.0.2

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -5 lines)			Patch
M	src/libGLESv2/Buffer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Buffer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/VertexBuffer9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/VertexDataManager.cpp	View	3 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages