Fix cleanupOrphans to actually work

Fix cleanupOrphans to actually work

The main issue was an inverted check (err != nil instead of err == nil), but
actually changed to use Glob() and only look at top-level dirs for removal,
instead of recursing through all the files and folders deleting one by one.

https://code.launchpad.net/~sidnei/juju-core/fix-cleanup-orphans/+merge/183878

(do not edit description out of merge proposal)

[sidnei.da.silva, 2013-09-04 13:44:15]

Please take a look.

[fwereade, 2013-09-04 13:57:53]

Grudging LGTM as is, enthusiastic one if you make the testing backdoors
explicit.

https://codereview.appspot.com/13242049/diff/1/worker/uniter/charm/deployer_t...
File worker/uniter/charm/deployer_test.go (right):

https://codereview.appspot.com/13242049/diff/1/worker/uniter/charm/deployer_t...
worker/uniter/charm/deployer_test.go:4: package charm
I'm not sure I love this. If it's just for d.path and d.current, can we maybe
add export_test functions to access them?

[sidnei.da.silva, 2013-09-04 14:41:49]

Please take a look.

[sidnei.da.silva, 2013-09-04 14:42:31]

https://codereview.appspot.com/13242049/diff/1/worker/uniter/charm/deployer_t...
File worker/uniter/charm/deployer_test.go (right):

https://codereview.appspot.com/13242049/diff/1/worker/uniter/charm/deployer_t...
worker/uniter/charm/deployer_test.go:4: package charm
On 2013/09/04 13:57:53, fwereade wrote:
> I'm not sure I love this. If it's just for d.path and d.current, can we maybe
> add export_test functions to access them? 

Done.

[fwereade, 2013-09-04 14:46:23]

LGTM with one tweak

https://codereview.appspot.com/13242049/diff/6001/worker/uniter/charm/deploye...
File worker/uniter/charm/deployer_test.go (right):

https://codereview.appspot.com/13242049/diff/6001/worker/uniter/charm/deploye...
worker/uniter/charm/deployer_test.go:214: c.Assert(updateDirs[0], gc.Equals,
current)
This is repeated often enough to deserve its own func, I think.

[sidnei.da.silva, 2013-09-04 14:56:24]

Please take a look.

https://codereview.appspot.com/13242049/diff/6001/worker/uniter/charm/deploye...
File worker/uniter/charm/deployer_test.go (right):

https://codereview.appspot.com/13242049/diff/6001/worker/uniter/charm/deploye...
worker/uniter/charm/deployer_test.go:214: c.Assert(updateDirs[0], gc.Equals,
current)
On 2013/09/04 14:46:23, fwereade wrote:
> This is repeated often enough to deserve its own func, I think.

Done.

[sidnei.da.silva, 2013-09-04 15:39:37]

Please take a look.