Issue 132410043: Modify ZebraBlockHeap to accept a heap to use for internal allocations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 132410043: Modify ZebraBlockHeap to accept a heap to use for internal allocations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by chrisha

Modified:
9 years, 8 months ago

Reviewers:
Sébastien Marchand

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Modify ZebraBlockHeap to accept a heap to use for internal allocations. This also adds an 'internal heap' to the BlockHeapManager. With this change the ZebraBlockHeap no reports internal memory use directly to the shadow memory. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2289

Patch Set 1 #

Patch Set 2 : Rebased. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -26 lines)			Patch
M	syzygy/agent/asan/heap_managers/block_heap_manager.h	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download
M	syzygy/agent/asan/heap_managers/block_heap_manager.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	syzygy/agent/asan/heap_managers/block_heap_manager_unittest.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	syzygy/agent/asan/heaps/zebra_block_heap.h	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	syzygy/agent/asan/heaps/zebra_block_heap.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	syzygy/agent/asan/heaps/zebra_block_heap_unittest.cc	View	1	3 chunks	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

chrisha

9 years, 8 months ago (2014-08-29 21:20:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 2289 (presubmit successful).

Expand All Messages | Collapse All Messages