Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 132210043: Add active_tiles as way of getting tiles. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by vmpstr
Modified:
10 years, 11 months ago
Reviewers:
nduca
CC:
trace-viewer-review_googlegroups.com
Base URL:
http://trace-viewer.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add active_tiles as way of getting tiles. Use active_tiles as a source of getting tiles, since this is where the chrome code is moving. We still support tiles, however, since we want to be able to process traces generated with older version of chrome. R=nduca@chromium.org, nduca Committed: https://code.google.com/p/trace-viewer/source/detail?r=1534

Patch Set 1 #

Patch Set 2 : typo fix #

Patch Set 3 : changes #

Patch Set 4 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M trace_viewer/cc/layer_tree_host_impl.html View 1 2 3 4 chunks +19 lines, -12 lines 0 comments Download
M trace_viewer/cc/layer_tree_quad_stack_view.html View 1 2 3 3 chunks +4 lines, -8 lines 0 comments Download
M trace_viewer/cc/layer_view_test.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M trace_viewer/cc/raster_task_sub_view_for_tasks_from_same_lthi.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M trace_viewer/cc/tile.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
vmpstr
PTAL
10 years, 11 months ago (2014-08-26 19:42:49 UTC) #1
nduca
can you rename this.tiles variable on LayerTreeHostImpl [js version] to be activeTiles? Otherwise lg.
10 years, 11 months ago (2014-08-26 21:40:06 UTC) #2
nduca
er, lgtm
10 years, 11 months ago (2014-08-26 21:40:12 UTC) #3
vmpstr
On 2014/08/26 21:40:06, nduca wrote: > can you rename this.tiles variable on LayerTreeHostImpl [js version] ...
10 years, 11 months ago (2014-08-26 21:51:34 UTC) #4
vmpstr
10 years, 11 months ago (2014-08-26 21:51:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as 1534 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b