Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 13202043: Work around infinite recursion in scanner on Chrome. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by kpreid2
Modified:
12 years, 6 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is a quick fix for <https://code.google.com/p/google-caja/issues/detail?id=1848> which should be replaced with something more principled once we figure out what that is. * Do not PLAIN_CALL any getter with a property named "stack". * Add a limit for depth of traversal. (This will cause the test to fail rather than run out of time/memory, in the event of any future similar problems.) Supporting changes: * Move all definitions in test-scan-guest relating to Error to one place and use new Ref definition style. @r5578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M tests/com/google/caja/plugin/test-scan-core.js View 13 chunks +24 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.js View 4 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 6 months ago (2013-08-24 00:27:03 UTC) #1
felix8a
12 years, 6 months ago (2013-08-24 03:32:12 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b