src/pkg/os/exec/exec_test.go - Issue 13183044: code review 13183044: os: dragonfly support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/os/exec/exec_test.go

Issue 13183044: code review 13183044: os: dragonfly support (Closed)

Patch Set: diff -r a109d5e7402e https://go.googlecode.com/hg/ Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/os/exec/exec_test.go

===================================================================

--- a/src/pkg/os/exec/exec_test.go

+++ b/src/pkg/os/exec/exec_test.go

@@ -445,7 +445,7 @@

// Determine which command to use to display open files.

ofcmd := "lsof"

switch runtime.GOOS {

- case "freebsd", "netbsd", "openbsd":

+ case "dragonfly", "freebsd", "netbsd", "openbsd":

ofcmd = "fstat"

}

@@ -514,6 +514,9 @@

os.Exit(1)

}

switch runtime.GOOS {

+ case "dragonfly":

+ // TODO(jsing): Determine why DragonFly is leaking

+ // file descriptors...

case "darwin":

// TODO(bradfitz): broken? Sometimes.

// http://golang.org/issue/2603

« no previous file with comments | « src/pkg/os/error_unix.go ('k') | src/pkg/os/exec/lp_unix.go » ('j') | no next file with comments »