Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(298)

Issue 13179044: upgrade to selenium 2.35.0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by felix8a
Modified:
12 years, 6 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The version of selenium we're using has some flakiness talking to firefox 24 (beta) Symptom is, occasional timeout when starting a browser. Upgrading to selenium 2.35.0 seems to fix that. I'm also upping the timeout for es53 scan to 5 minutes, because it sometimes times out when I'm doing something else at the same time. (this CL doesn't include the update to selenium-standalone.jar because codereview barfs on huge files like that)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M tests/com/google/caja/plugin/MainBrowserTest.java View 1 chunk +1 line, -1 line 0 comments Download
M third_party/java/webdriver/README View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/java/webdriver/VERSION View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 6 months ago (2013-08-23 01:05:46 UTC) #1
kpreid2
LGTM
12 years, 6 months ago (2013-08-23 17:47:58 UTC) #2
felix8a
12 years, 6 months ago (2013-08-23 17:54:06 UTC) #3
@r5575
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b