add ses-explicit to tests, and always capture some browser results

This adds ses/explicit.html to the list of tests run,
so we can gather a record of how browsers behave.

This also modifies browser capture (in a dumb/easy way)
so that some test runs will always be captured
whether they pass or fail.

[MarkM, 2013-08-23 00:26:23]

Quick question: Would explicit.html still run standalone with only SES, in the
absence of the test harness in question?

[felix8a, 2013-08-23 01:02:03]

On 2013/08/23 00:26:23, MarkM wrote:
> Quick question: Would explicit.html still run standalone with only SES, in the
> absence of the test harness in question?

yes, it runs fine standalone without the test harness.

[MarkM, 2013-08-23 01:12:25]

ses/* part LGTM

[kpreid2, 2013-08-23 17:46:08]

https://codereview.appspot.com/13171045/diff/1/src/com/google/caja/ses/explic...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/13171045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:73: var testSignals = gebi('testSignals');
I'd like to see the Caja test glue factored out so that the separation between
SES issues and Caja issues is clearer.

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/B...
File tests/com/google/caja/plugin/BrowserTestCase.java (right):

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/B...
tests/com/google/caja/plugin/BrowserTestCase.java:179:
label.startsWith("guest-scan-") ||
For now, at least make this method return false and override it in
MainBrowserTest.

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/b...
File tests/com/google/caja/plugin/browser-tests.json (right):

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/b...
tests/com/google/caja/plugin/browser-tests.json:14: "label": "ses-explicit",
This should go in ses-tests.json, no?

[felix8a, 2013-08-23 20:22:27]

This adds ses/explicit.html to the list of tests run,
so we can gather a record of how browsers behave.

This also modifies browser capture (in a dumb/easy way)
so that some test runs will always be captured
whether they pass or fail.

[felix8a, 2013-08-23 20:22:35]

new snapshot

https://codereview.appspot.com/13171045/diff/1/src/com/google/caja/ses/explic...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/13171045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:73: var testSignals = gebi('testSignals');
On 2013/08/23 17:46:08, kpreid2 wrote:
> I'd like to see the Caja test glue factored out so that the separation between
> SES issues and Caja issues is clearer.

Done.

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/B...
File tests/com/google/caja/plugin/BrowserTestCase.java (right):

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/B...
tests/com/google/caja/plugin/BrowserTestCase.java:179:
label.startsWith("guest-scan-") ||
On 2013/08/23 17:46:08, kpreid2 wrote:
> For now, at least make this method return false and override it in
> MainBrowserTest.

Done.

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/b...
File tests/com/google/caja/plugin/browser-tests.json (right):

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/b...
tests/com/google/caja/plugin/browser-tests.json:14: "label": "ses-explicit",
On 2013/08/23 17:46:08, kpreid2 wrote:
> This should go in ses-tests.json, no?

Done.

[kpreid2, 2013-08-23 20:26:06]

LGTM

[felix8a, 2013-08-23 20:27:58]

@r5577