Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(191)

Issue 131430043: Add a new method to check if an address point to the beginning of an user alloc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by Sébastien Marchand
Modified:
6 years, 8 months ago
Reviewers:
chrisha
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add a new method to check if an address point to the beginning of an user alloc This will be useful to check if a block has been allocated without guards. R=chrisha@chromium.org BUG= Committed: https://code.google.com/p/sawbuck/source/detail?r=2275

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M syzygy/agent/asan/heap_managers/block_heap_manager.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M syzygy/agent/asan/shadow.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M syzygy/agent/asan/shadow.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M syzygy/agent/asan/shadow_unittest.cc View 1 2 4 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Sébastien Marchand
PTAL.
6 years, 8 months ago (2014-08-27 20:12:42 UTC) #1
chrisha
lgtm https://codereview.appspot.com/131430043/diff/20001/syzygy/agent/asan/shadow.h File syzygy/agent/asan/shadow.h (right): https://codereview.appspot.com/131430043/diff/20001/syzygy/agent/asan/shadow.h#newcode219 syzygy/agent/asan/shadow.h:219: // Checks it the address @p addr correspond ...
6 years, 8 months ago (2014-08-27 20:22:36 UTC) #2
Sébastien Marchand
Thanks, committing. https://codereview.appspot.com/131430043/diff/20001/syzygy/agent/asan/shadow.h File syzygy/agent/asan/shadow.h (right): https://codereview.appspot.com/131430043/diff/20001/syzygy/agent/asan/shadow.h#newcode219 syzygy/agent/asan/shadow.h:219: // Checks it the address @p addr ...
6 years, 8 months ago (2014-08-27 20:36:38 UTC) #3
Sébastien Marchand
6 years, 8 months ago (2014-08-27 20:37:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 2275.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b