Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

Issue 1313042: Add JSONP-style onload "handler" to JsServlet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by johnfargo
Modified:
15 years, 10 months ago
Reviewers:
Paul Lindner, zhoresh, shindig.remailer, mhermanto, jtarrio
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Particularly for container JavaScript but in other cases as well, clients loading JavaScript from Shindig occasionally do so using dynamic loading. When doing so, they need to know when the servlet's JS has completed loading, which is difficult to impossible to do across all browsers consistently in this case. This CL adds support for the "onload" query parameter to JsServlet. Its value is the name of a method defined globally that indicates loading has completed, the call appended to the tail of the request. The param is sanitized by a simple regular expression and JS escaping.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java View 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2
johnfargo
15 years, 10 months ago (2010-05-26 18:13:02 UTC) #1
Paul Lindner
15 years, 10 months ago (2010-05-26 18:18:33 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b