Issue 13113044: Build fix: not all types support precisions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13113044: Build fix: not all types support precisions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Zhenyao Mo

Modified:
10 years, 8 months ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Build fix: not all types support precisions. Currently Angle translator made the wrong assumption that all variables have a precision, and ASSERT that. BUG=276031 TBR=alokp@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=827fb6a

Patch Set 1 #

Patch Set 2 : first #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -5 lines)			Patch
M	include/GLSLANG/ShaderLang.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/common/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/ShaderLang.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Zhenyao Mo

Alok, I'll land this with TBR so the current chrome debug build won't crash with ...

10 years, 8 months ago (2013-08-20 01:05:49 UTC) #1

Zhenyao Mo

10 years, 8 months ago (2013-08-20 01:06:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r827fb6a (presubmit successful).

Expand All Messages | Collapse All Messages