Issue 13105043: all: standardise gocheck imports E-R

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13105043: all: standardise gocheck imports E-R

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rog

Modified:
10 years, 8 months ago

Reviewers:
dimitern, mp+180850

Visibility:
Public.

Description

all: standardise gocheck imports E-R Next in line. https://code.launchpad.net/~rogpeppe/juju-core/370-gocheck-cleanup-e-r/+merge/180850 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1106 lines, -1104 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/boilerplate_config_test.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/cert_internal_test.go	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	environs/cert_test.go	View	4 chunks	+22 lines, -22 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	12 chunks	+33 lines, -33 lines	0 comments	Download
M	environs/cloudinit/suite_test.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	environs/cloudinit_test.go	View	7 chunks	+32 lines, -32 lines	0 comments	Download
M	environs/config/home_test.go	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	environs/emptystorage_test.go	View	3 chunks	+22 lines, -22 lines	0 comments	Download
M	environs/jujutest/jujutest_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	environs/jujutest/metadata_test.go	View	1 chunk	+18 lines, -18 lines	0 comments	Download
M	environs/localstorage/backend_test.go	View	12 chunks	+34 lines, -34 lines	0 comments	Download
M	environs/localstorage/storage_test.go	View	6 chunks	+31 lines, -31 lines	0 comments	Download
M	environs/mongo_test.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/open_test.go	View	5 chunks	+33 lines, -33 lines	0 comments	Download
M	environs/polling_test.go	View	4 chunks	+16 lines, -16 lines	0 comments	Download
M	environs/provider/dummy/config_test.go	View	5 chunks	+11 lines, -11 lines	0 comments	Download
M	environs/provider/dummy/environs_test.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	environs/provider/ec2/config_test.go	View	8 chunks	+31 lines, -31 lines	0 comments	Download
M	environs/provider/ec2/image_test.go	View	7 chunks	+23 lines, -23 lines	0 comments	Download
M	environs/provider/ec2/live_test.go	View	14 chunks	+75 lines, -75 lines	0 comments	Download
M	environs/provider/ec2/local_test.go	View	19 chunks	+78 lines, -78 lines	0 comments	Download
M	environs/provider/ec2/storage_test.go	View	2 chunks	+14 lines, -14 lines	0 comments	Download
M	environs/provider/ec2/suite_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/provider/local/local_test.go	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	environs/provider/openstack/live_test.go	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	environs/provider/openstack/local_test.go	View	20 chunks	+120 lines, -120 lines	0 comments	Download
M	environs/provider/openstack/provider_test.go	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	environs/state_test.go	View	6 chunks	+61 lines, -61 lines	0 comments	Download
M	environs/tools_test.go	View	14 chunks	+34 lines, -34 lines	0 comments	Download
M	instance/container_test.go	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	instance/instance_test.go	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	juju/apiconn_test.go	View	3 chunks	+12 lines, -12 lines	0 comments	Download
M	juju/conn_test.go	View	18 chunks	+173 lines, -173 lines	0 comments	Download
M	log/log_test.go	View	2 chunks	+19 lines, -19 lines	0 comments	Download
M	log/syslog/config_test.go	View	3 chunks	+19 lines, -19 lines	0 comments	Download
M	rpc/jsoncodec/codec_test.go	View	10 chunks	+42 lines, -42 lines	0 comments	Download
M	rpc/rpc_test.go	View	22 chunks	+76 lines, -76 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

10 years, 8 months ago (2013-08-19 12:04:07 UTC) #2

On 2013/08/19 12:02:16, rog wrote:
> Please take a look.

LGTM, since it's automatic and there are no other changes.

Expand All Messages | Collapse All Messages