Issue 13094046: http Issue 225: When redirects on 303 are changed to GET, they must have empty content

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13094046: http Issue 225: When redirects on 303 are changed to GET, they must have empty content (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by ngmiceli

Modified:
12 years ago

Reviewers:
yanivi

Base URL:
https://code.google.com/p/google-http-java-client

Visibility:
Public.

More Reviews

Description

http Issue 225: When redirects on 303 are changed to GET, they must have empty content https://code.google.com/p/google-http-java-client/issues/detail?id=225 Previously, a POST with content on 303 would cause the following: java.lang.IllegalArgumentException: GET with non-zero content length is not supported at com.google.api.client.repackaged.com.google.common.base.Preconditions.checkArgument(Preconditions.java:119) at com.google.api.client.util.Preconditions.checkArgument(Preconditions.java:69) at com.google.api.client.http.javanet.NetHttpRequest.execute(NetHttpRequest.java:86) at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:960)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added upgrade warning #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
	M	google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

yanivi

LGTM https://codereview.appspot.com/13094046/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java File google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java (right): https://codereview.appspot.com/13094046/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java#newcode1103 google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:1103: * </p> add an upgrade warning to explain ...

12 years ago (2013-08-22 19:43:04 UTC) #2

ngmiceli

PTAL https://codereview.appspot.com/13094046/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java File google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java (right): https://codereview.appspot.com/13094046/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java#newcode1103 google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:1103: * </p> On 2013/08/22 19:43:05, yanivi wrote: > ...

12 years ago (2013-08-23 13:35:36 UTC) #3

LGTM

Expand All Messages | Collapse All Messages