Issue 130750044: Stop calling "new WeakMap(true)" as that is not correct ES6.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130750044: Stop calling "new WeakMap(true)" as that is not correct ES6. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by MarkM

Modified:
11 years, 6 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixes https://code.google.com/p/google-caja/issues/detail?id=1932

Patch Set 1 #

Patch Set 2 : Stop calling "new WeakMap(true)" as that is not correct ES6. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	src/com/google/caja/plugin/domado.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/ses-promise.js	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/com/google/caja/ses/ejectorsGuardsTrademarks.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kpreid2

LGTM Thanks. I thought I had cleaned up all of these a while ago. Did ...

11 years, 6 months ago (2014-08-15 17:46:30 UTC) #2

MarkM

Fixes https://code.google.com/p/google-caja/issues/detail?id=1932

11 years, 6 months ago (2014-08-15 18:57:39 UTC) #3

MarkM

11 years, 6 months ago (2014-08-15 18:59:06 UTC) #4

On 2014/08/15 17:46:30, kpreid2 wrote:
> LGTM
> 
> Thanks. I thought I had cleaned up all of these a while ago.
> 
> Did you search for all occurrences? If not, that would be a good thing to do
> just to make sure this is completely done.

Yup. There were two more. Done.

Expand All Messages | Collapse All Messages