Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(425)

Issue 130740043: [MIPS64] Add support for MIPS64 in protobuf (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Petar Jovanovic
Modified:
11 years, 6 months ago
Reviewers:
xiaofeng, pliard, jieluo
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Description

[MIPS64] Add support for MIPS64 in protobuf Add support for atomic ops for MIPS64. Related change in Chromium: https://codereview.chromium.org/450343002/ BUG= https://code.google.com/p/chromium/issues/detail?id=400684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -3 lines) Patch
M src/google/protobuf/stubs/atomicops.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google/protobuf/stubs/atomicops_internals_mips_gcc.h View 3 chunks +128 lines, -2 lines 0 comments Download
M src/google/protobuf/stubs/platform_macros.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Petar Jovanovic
PTAL.
11 years, 7 months ago (2014-08-15 14:21:33 UTC) #1
xiaofeng
Hi Petar, I noticed that the change made in chromium is different from the change ...
11 years, 7 months ago (2014-08-15 18:08:35 UTC) #2
Petar Jovanovic
On 2014/08/15 18:08:35, xiaofeng wrote: > Hi Petar, > I noticed that the change made ...
11 years, 7 months ago (2014-08-15 21:09:56 UTC) #3
Petar Jovanovic
On 2014/08/15 21:09:56, Petar Jovanovic wrote: > On 2014/08/15 18:08:35, xiaofeng wrote: > > Hi ...
11 years, 6 months ago (2014-08-20 13:58:41 UTC) #4
xiaofeng
LGTM Jie, can you help apply this patch to protobuf svn? On Wed, Aug 20, ...
11 years, 6 months ago (2014-08-20 17:53:20 UTC) #5
jieluo
Done. It will be released with protobuf 2.6.0 very soon. https://code.google.com/p/protobuf/source/detail?r=571 2014-08-20 10:53 GMT-07:00 Feng ...
11 years, 6 months ago (2014-08-20 18:28:12 UTC) #6
Petar Jovanovic
11 years, 6 months ago (2014-08-22 11:17:38 UTC) #7
On 2014/08/20 18:28:12, jieluo wrote:
> Done. It will be released with protobuf 2.6.0 very soon.
> 
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b