[MIPS64] Add support for MIPS64 in protobuf

[MIPS64] Add support for MIPS64 in protobuf

Add support for atomic ops for MIPS64.
Related change in Chromium:

https://codereview.chromium.org/450343002/

BUG= https://code.google.com/p/chromium/issues/detail?id=400684

[Petar Jovanovic, 2014-08-15 14:21:33]

PTAL.

[xiaofeng, 2014-08-15 18:08:35]

Hi Petar,
I noticed that the change made in chromium is different from the change made in
V8:
V8 version: https://codereview.chromium.org/371923006
Chromium version: https://codereview.chromium.org/450343002/

The V8 version adds a new atomicops_internals_mips64_gcc.h header file while the
chromium version adds 64bit support to the existing
atomicops_internals_mips_gcc.h header file.

Why do they have this difference?

Coincidently I received a patch from a googler adding mips64 support to our
internal dev branch and I asked him to use the v8 version. Did not noticed a
change has been made in chromium also.

[Petar Jovanovic, 2014-08-15 21:09:56]

On 2014/08/15 18:08:35, xiaofeng wrote:
> Hi Petar,
> I noticed that the change made in chromium is different from the change made
in
> V8:
> V8 version: https://codereview.chromium.org/371923006
> Chromium version: https://codereview.chromium.org/450343002/
> 
> The V8 version adds a new atomicops_internals_mips64_gcc.h header file while
the
> chromium version adds 64bit support to the existing
> atomicops_internals_mips_gcc.h header file.
> 
> Why do they have this difference?
> 
> Coincidently I received a patch from a googler adding mips64 support to our
> internal dev branch and I asked him to use the v8 version. Did not noticed a
> change has been made in chromium also.

Hi Xiaofeng,

The atomic ops implementations are the same for v8 and Chromium. At this
very moment, the Chromium version is most up-to-date and v8 will cherry
pick minor changes that have just been added to two functions
(NoBarrier_AtomicIncrement and NoBarrier_AtomicIncrement for mips64) in
Chromium version.

Having said this, the implementations are indeed placed in different
modules, as we wanted to avoid duplicating the content when we created a
mips64 version for Chromium (since all 32-bit ops remain the same).

Regards,
Petar

[Petar Jovanovic, 2014-08-20 13:58:41]

On 2014/08/15 21:09:56, Petar Jovanovic wrote:
> On 2014/08/15 18:08:35, xiaofeng wrote:
> > Hi Petar,
> > I noticed that the change made in chromium is different from the change made
> in
> > V8:
> > V8 version: https://codereview.chromium.org/371923006
> > Chromium version: https://codereview.chromium.org/450343002/
> > 
> > The V8 version adds a new atomicops_internals_mips64_gcc.h header file while
> the
> > chromium version adds 64bit support to the existing
> > atomicops_internals_mips_gcc.h header file.
> > 
> > Why do they have this difference?
> > 
> > Coincidently I received a patch from a googler adding mips64 support to our
> > internal dev branch and I asked him to use the v8 version. Did not noticed a
> > change has been made in chromium also.
> 
> Hi Xiaofeng,
> 
> The atomic ops implementations are the same for v8 and Chromium. At this
> very moment, the Chromium version is most up-to-date and v8 will cherry
> pick minor changes that have just been added to two functions
> (NoBarrier_AtomicIncrement and NoBarrier_AtomicIncrement for mips64) in
> Chromium version.
> 
> Having said this, the implementations are indeed placed in different
> modules, as we wanted to avoid duplicating the content when we created a
> mips64 version for Chromium (since all 32-bit ops remain the same).
> 
> Regards,
> Petar

ping.

[xiaofeng, 2014-08-20 17:53:20]

LGTM

Jie, can you help apply this patch to protobuf svn?


On Wed, Aug 20, 2014 at 6:58 AM, <petarj@mips.com> wrote:

> On 2014/08/15 21:09:56, Petar Jovanovic wrote:
>
>> On 2014/08/15 18:08:35, xiaofeng wrote:
>> > Hi Petar,
>> > I noticed that the change made in chromium is different from the
>>
> change made
>
>> in
>> > V8:
>> > V8 version: https://codereview.chromium.org/371923006
>> > Chromium version: https://codereview.chromium.org/450343002/
>> >
>> > The V8 version adds a new atomicops_internals_mips64_gcc.h header
>>
> file while
>
>> the
>> > chromium version adds 64bit support to the existing
>> > atomicops_internals_mips_gcc.h header file.
>> >
>> > Why do they have this difference?
>> >
>> > Coincidently I received a patch from a googler adding mips64 support
>>
> to our
>
>> > internal dev branch and I asked him to use the v8 version. Did not
>>
> noticed a
>
>> > change has been made in chromium also.
>>
>
>  Hi Xiaofeng,
>>
>
>  The atomic ops implementations are the same for v8 and Chromium. At
>>
> this
>
>> very moment, the Chromium version is most up-to-date and v8 will
>>
> cherry
>
>> pick minor changes that have just been added to two functions
>> (NoBarrier_AtomicIncrement and NoBarrier_AtomicIncrement for mips64)
>>
> in
>
>> Chromium version.
>>
>
>  Having said this, the implementations are indeed placed in different
>> modules, as we wanted to avoid duplicating the content when we created
>>
> a
>
>> mips64 version for Chromium (since all 32-bit ops remain the same).
>>
>
>  Regards,
>> Petar
>>
>
> ping.
>
> https://codereview.appspot.com/130740043/
>

[jieluo, 2014-08-20 18:28:12]

Done. It will be released with protobuf 2.6.0 very soon.


https://code.google.com/p/protobuf/source/detail?r=571

2014-08-20 10:53 GMT-07:00 Feng Xiao <xiaofeng@google.com>:
> LGTM
>
> Jie, can you help apply this patch to protobuf svn?
>
>
>
> On Wed, Aug 20, 2014 at 6:58 AM, <petarj@mips.com> wrote:
>>
>> On 2014/08/15 21:09:56, Petar Jovanovic wrote:
>>>
>>> On 2014/08/15 18:08:35, xiaofeng wrote:
>>> > Hi Petar,
>>> > I noticed that the change made in chromium is different from the
>>
>> change made
>>>
>>> in
>>> > V8:
>>> > V8 version: https://codereview.chromium.org/371923006
>>> > Chromium version: https://codereview.chromium.org/450343002/
>>> >
>>> > The V8 version adds a new atomicops_internals_mips64_gcc.h header
>>
>> file while
>>>
>>> the
>>> > chromium version adds 64bit support to the existing
>>> > atomicops_internals_mips_gcc.h header file.
>>> >
>>> > Why do they have this difference?
>>> >
>>> > Coincidently I received a patch from a googler adding mips64 support
>>
>> to our
>>>
>>> > internal dev branch and I asked him to use the v8 version. Did not
>>
>> noticed a
>>>
>>> > change has been made in chromium also.
>>
>>
>>> Hi Xiaofeng,
>>
>>
>>> The atomic ops implementations are the same for v8 and Chromium. At
>>
>> this
>>>
>>> very moment, the Chromium version is most up-to-date and v8 will
>>
>> cherry
>>>
>>> pick minor changes that have just been added to two functions
>>> (NoBarrier_AtomicIncrement and NoBarrier_AtomicIncrement for mips64)
>>
>> in
>>>
>>> Chromium version.
>>
>>
>>> Having said this, the implementations are indeed placed in different
>>> modules, as we wanted to avoid duplicating the content when we created
>>
>> a
>>>
>>> mips64 version for Chromium (since all 32-bit ops remain the same).
>>
>>
>>> Regards,
>>> Petar
>>
>>
>> ping.
>>
>> https://codereview.appspot.com/130740043/
>
>

[Petar Jovanovic, 2014-08-22 11:17:38]

On 2014/08/20 18:28:12, jieluo wrote:
> Done. It will be released with protobuf 2.6.0 very soon.
> 
Thank you!