Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(247)

Issue 13060045: remove dom2property from css whitelist (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by felix8a
Modified:
12 years, 6 months ago
Reviewers:
MikeSamuel, kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The css whitelist has an element 'dom2property' that's intended to map a css name like 'margin-left' to a dom name like 'marginLeft'. I'm eliminating it, because: 1. It's unnecessary. The name conversion is regular except for float->cssFloat, and it's unlikely that any other css properties will be irregular. 2. It's a maintenance hazard. Specifying an incorrect dom2property will cause mysterious failures. And failing to specify a correct dom2property may also cause mysterious failures. There was also legacy support for style->styleFloat instead of cssFloat, which is for IE<=8, which we're not supporting, so I'm removing the styleFloat code.

Patch Set 1 #

Total comments: 9

Patch Set 2 : remove dom2property from css whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -432 lines) Patch
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 1 5 chunks +0 lines, -41 lines 0 comments Download
M src/com/google/caja/lang/css/CssSchema.java View 1 5 chunks +4 lines, -34 lines 0 comments Download
M src/com/google/caja/lang/css/css3-defs.json View 1 55 chunks +117 lines, -260 lines 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 5 chunks +31 lines, -55 lines 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 1 2 chunks +0 lines, -14 lines 0 comments Download
M tests/com/google/caja/lang/css/CssSchemaTest.java View 1 2 chunks +0 lines, -11 lines 0 comments Download
M tests/com/google/caja/plugin/test-domado-dom-guest.html View 1 2 chunks +1 line, -12 lines 0 comments Download
M tests/com/google/caja/plugin/test-domado-special-guest.html View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7
felix8a
12 years, 6 months ago (2013-08-21 05:53:08 UTC) #1
felix8a
+kpreid since mikesamuel is on vacation. feel free to ignore, this isn't urgent
12 years, 6 months ago (2013-08-22 20:40:49 UTC) #2
kpreid2
LGTM https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json File src/com/google/caja/lang/css/css3-defs.json (right): https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json#newcode5 src/com/google/caja/lang/css/css3-defs.json:5: "This differs from the spec in that it ...
12 years, 6 months ago (2013-08-22 20:55:26 UTC) #3
felix8a
The css whitelist has an element 'dom2property' that's intended to map a css name like ...
12 years, 6 months ago (2013-08-22 21:40:05 UTC) #4
felix8a
updated snapshot https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json File src/com/google/caja/lang/css/css3-defs.json (right): https://codereview.appspot.com/13060045/diff/1/src/com/google/caja/lang/css/css3-defs.json#newcode5 src/com/google/caja/lang/css/css3-defs.json:5: "This differs from the spec in that ...
12 years, 6 months ago (2013-08-22 21:40:23 UTC) #5
kpreid2
LGTM
12 years, 6 months ago (2013-08-22 21:46:58 UTC) #6
felix8a
12 years, 6 months ago (2013-08-22 23:58:17 UTC) #7
Message was sent while issue was closed.
@r5573
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b