Issue 13056043: Expect the symptoms seen on Safari 5

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13056043: Expect the symptoms seen on Safari 5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by MarkM

Modified:
12 years, 6 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : Expect the symptoms seen on Safari 5 #

Total comments: 2

Patch Set 3 : Expect the symptoms seen on Safari 5 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -70 lines)			Patch
	M	src/com/google/caja/ses/repairES5.js	View	1 2	59 chunks	+78 lines, -70 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kpreid2

LGTM https://codereview.appspot.com/13056043/diff/2001/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): https://codereview.appspot.com/13056043/diff/2001/src/com/google/caja/ses/repairES5.js#newcode4305 src/com/google/caja/ses/repairES5.js:4305: 'http://code.google.com/p/v8/issues/detail?id=2470', https: is canonical

12 years, 6 months ago (2013-08-16 16:30:38 UTC) #3

MarkM

12 years, 6 months ago (2013-08-16 17:12:36 UTC) #4

https://codereview.appspot.com/13056043/diff/2001/src/com/google/caja/ses/rep...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/13056043/diff/2001/src/com/google/caja/ses/rep...
src/com/google/caja/ses/repairES5.js:4305:
'http://code.google.com/p/v8/issues/detail?id=2470',
On 2013/08/16 16:30:38, kpreid2 wrote:
> https: is canonical

Done.

Expand All Messages | Collapse All Messages